Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mail: clean up starredPersonas #159466

Conversation

phenix-factory
Copy link
Contributor

@phenix-factory phenix-factory commented Mar 27, 2024

Before this PR, _message_format sent all of the users that starred a message to
the JS code.
Since #162065, this behavior is not necessary
anymore and a boolean can be used.

@robodoo
Copy link
Contributor

robodoo commented Mar 27, 2024

Pull request status dashboard.

@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch from e9ff605 to b2968cc Compare March 27, 2024 13:49
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 27, 2024
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch 3 times, most recently from a4174fc to bd5af49 Compare March 28, 2024 08:04
@phenix-factory phenix-factory marked this pull request as ready for review March 28, 2024 09:17
@C3POdoo C3POdoo requested review from a team March 28, 2024 09:20
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch 7 times, most recently from 2237175 to ee21396 Compare April 8, 2024 12:34
@seb-odoo seb-odoo marked this pull request as draft April 8, 2024 12:35
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch 9 times, most recently from cd53a36 to 5929ed5 Compare April 15, 2024 10:55
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch 4 times, most recently from 27e1b3c to 118e4ea Compare April 17, 2024 11:20
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch 8 times, most recently from 6a3fd01 to 20c14ef Compare April 23, 2024 12:52
@phenix-factory phenix-factory changed the title [IMP] mail: refactor starred message [IMP] mail: clean up starredPersonas Apr 23, 2024
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch 2 times, most recently from 0f7d74b to c446c71 Compare April 23, 2024 12:56
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch 4 times, most recently from c32b832 to 9808368 Compare May 21, 2024 06:05
@phenix-factory phenix-factory marked this pull request as ready for review May 21, 2024 07:39
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch 3 times, most recently from b5b9dcd to ce1041e Compare May 23, 2024 06:28
Copy link
Contributor

@seb-odoo seb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one occurrence of starredPersonas left in test file.

@robodoo delegate+

@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch from ce1041e to 54a514a Compare May 27, 2024 13:26
Before this PR, `_message_format` sent all of the users that starred a message to
the JS code.
Since odoo#162065, this behavior is not necessary
anymore and a boolean can be used.
@phenix-factory phenix-factory force-pushed the master-refactor-starred-message-did branch from 54a514a to b465531 Compare May 27, 2024 13:38
@phenix-factory
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request May 27, 2024
Before this PR, `_message_format` sent all of the users that starred a message to
the JS code.
Since #162065, this behavior is not necessary
anymore and a boolean can be used.

closes #159466

Signed-off-by: Didier Debondt (did) <did@odoo.com>
robodoo pushed a commit that referenced this pull request May 27, 2024
Before this PR, `_message_format` sent all of the users that starred a message to
the JS code.
Since #162065, this behavior is not necessary
anymore and a boolean can be used.

closes #159466

Signed-off-by: Didier Debondt (did) <did@odoo.com>
@robodoo robodoo closed this May 27, 2024
@robodoo robodoo added the 17.3 label May 27, 2024
@alexkuhn alexkuhn deleted the master-refactor-starred-message-did branch May 28, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants