-
Notifications
You must be signed in to change notification settings - Fork 23.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] mail: clean up starredPersonas #159466
Closed
phenix-factory
wants to merge
1
commit into
odoo:master
from
odoo-dev:master-refactor-starred-message-did
Closed
[IMP] mail: clean up starredPersonas #159466
phenix-factory
wants to merge
1
commit into
odoo:master
from
odoo-dev:master-refactor-starred-message-did
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
from
March 27, 2024 13:49
e9ff605
to
b2968cc
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
3 times, most recently
from
March 28, 2024 08:04
a4174fc
to
bd5af49
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
7 times, most recently
from
April 8, 2024 12:34
2237175
to
ee21396
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
9 times, most recently
from
April 15, 2024 10:55
cd53a36
to
5929ed5
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
4 times, most recently
from
April 17, 2024 11:20
27e1b3c
to
118e4ea
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
8 times, most recently
from
April 23, 2024 12:52
6a3fd01
to
20c14ef
Compare
phenix-factory
changed the title
[IMP] mail: refactor starred message
[IMP] mail: clean up starredPersonas
Apr 23, 2024
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
2 times, most recently
from
April 23, 2024 12:56
0f7d74b
to
c446c71
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
4 times, most recently
from
May 21, 2024 06:05
c32b832
to
9808368
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
3 times, most recently
from
May 23, 2024 06:28
b5b9dcd
to
ce1041e
Compare
seb-odoo
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one occurrence of starredPersonas
left in test file.
@robodoo delegate+
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
from
May 27, 2024 13:26
ce1041e
to
54a514a
Compare
Before this PR, `_message_format` sent all of the users that starred a message to the JS code. Since odoo#162065, this behavior is not necessary anymore and a boolean can be used.
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
from
May 27, 2024 13:38
54a514a
to
b465531
Compare
@robodoo r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
_message_format
sent all of the users that starred a message tothe JS code.
Since #162065, this behavior is not necessary
anymore and a boolean can be used.